cloud-fan commented on a change in pull request #28833:
URL: https://github.com/apache/spark/pull/28833#discussion_r451248585
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
##########
@@ -2309,6 +2310,126 @@ class HiveDDLSuite
}
}
+ test("SPARK-20680: Spark-sql do not support for unknown column datatype") {
+ withTable("t") {
+ withView("tabUnknownType") {
+ hiveClient.runSqlHive("CREATE TABLE t (t1 int)")
+ hiveClient.runSqlHive("INSERT INTO t VALUES (3)")
+ hiveClient.runSqlHive("CREATE VIEW tabUnknownType AS SELECT NULL AS
col FROM t")
+ checkAnswer(spark.table("tabUnknownType"), Row(null))
+ // No exception shows
+ val desc = spark.sql("DESC tabUnknownType").collect().toSeq
+ assert(desc.contains(Row("col", NullType.simpleString, null)))
+ }
+ }
+
+ // Forbid CTAS with unknown type
+ withTable("t1", "t2", "t3") {
+ val e1 = intercept[AnalysisException] {
+ spark.sql("CREATE TABLE t1 USING PARQUET AS SELECT null as null_col")
+ }.getMessage
+ assert(e1.contains("Cannot create tables with unknown type"))
+
+ val e2 = intercept[AnalysisException] {
+ spark.sql("CREATE TABLE t2 AS SELECT null as null_col")
Review comment:
can we use `STORE AS` to create hive table explicitly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
