cloud-fan commented on a change in pull request #29026:
URL: https://github.com/apache/spark/pull/29026#discussion_r451258078
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/UnsafeRowSuite.scala
##########
@@ -178,4 +178,14 @@ class UnsafeRowSuite extends SparkFunSuite {
// Makes sure hashCode on unsafe array won't crash
unsafeRow.getArray(0).hashCode()
}
+
+ test("SPARK-32018: setDecimal with overflowed value") {
+ val d1 = new
Decimal().set(BigDecimal("10000000000000000000")).toPrecision(38, 18)
+ val row = InternalRow.apply(d1)
+ val unsafeRow = UnsafeProjection.create(Array[DataType](DecimalType(38,
18))).apply(row)
+ assert(unsafeRow.getDecimal(0, 38, 18) === d1)
+ val d2 = (d1 * Decimal(10)).toPrecision(39, 18)
+ unsafeRow.setDecimal(0, d2, 38)
+ assert(unsafeRow.getDecimal(0, 38, 18) === null)
Review comment:
`UnsafeRow` is a low-level entity and doesn't respect ansi flag.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
