dongjoon-hyun commented on a change in pull request #29057:
URL: https://github.com/apache/spark/pull/29057#discussion_r452596266



##########
File path: .github/workflows/master.yml
##########
@@ -1,156 +1,238 @@
 name: master
 
 on:
-  push:

Review comment:
       What do you mean by `smoke tests` if you are not running all tests? PR 
Builder cannot be the same because it's just based on the master branch 
snapshot on the starting time. So, I don't agree with 'all tests again'.
   >  instead of running all tests again. 
   
   However, please proceed toward what you need. Everything-else can be done 
after merging this initial PR.
   
   BTW, please note that this PR can cause a significant delay if there is no 
enough resource given from ASF foundation.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to