yaooqinn opened a new pull request #29064:
URL: https://github.com/apache/spark/pull/29064


   ### What changes were proposed in this pull request?
   
   This PR adds the SQL standard command - `SET TIME ZONE` to the current 
default time zone displacement for the current SQL-session, which is the same 
as the existing `set spark.sql.session.timeZone=xxx'.
   
   What's more, the `SET TIME ZONE ALL` is added as an extension to list all 
the supported region-based Zone IDs supported.
   
   The `SET TIME ZONE` with intervals are not considered, because it has to be 
qualified with interval qualifier HOUR TO MINUTE which is not fully supported 
in Spark now.
   
   All in all, this PR adds syntax as following,
   
   ```
   SET TIME ZONE LOCAL;
   SET TIME ZONE 'valid time zone';
   SET TIME ZONE ALL; (extended)
   ```
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   ANSI compliance and supply pure SQL users a way to retrieve all supported 
TimeZones
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as 
the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes 
- provide the console output, description and/or an example to show the 
behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to 
the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   yes, add new syntax.
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some 
test cases that check the changes thoroughly including negative and positive 
cases if possible.
   If it was tested in a way different from regular unit tests, please clarify 
how you tested step by step, ideally copy and paste-able, so that other 
reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why 
it was difficult to add.
   -->
   
   add unit tests.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to