GitHub user marmbrus opened a pull request:

    https://github.com/apache/spark/pull/5189

    [SPARK-6145][SQL] fix ORDER BY on nested fields

    This PR is based on work by @cloud-fan in #4904, but with two differences:
     - We isolate the logic for Sort's special handling into 
`ResolveSortReferences`
     - We avoid creating UnresolvedGetField expressions during resolution.  
Instead we either resolve GetField or we return None.  This avoids us going 
down the wrong path early on.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/marmbrus/spark nestedOrderBy

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/5189.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5189
    
----
commit dee51f0471e4a44478385246843111757b2ab5f6
Author: Michael Armbrust <mich...@databricks.com>
Date:   2015-03-25T20:23:28Z

    Handle nested fields in sorts correctly.

commit 490d50fe43d31dd1ebd22c4269421f37b30aebc7
Author: Michael Armbrust <mich...@databricks.com>
Date:   2015-03-25T20:32:44Z

    Avoid adding UnresolvedGetFields when we are resolving.

commit e35b27c482f624b9a7fdb8eb27eb00aed536e6fc
Author: Michael Armbrust <mich...@databricks.com>
Date:   2015-03-25T22:05:07Z

    revert changes

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to