cloud-fan commented on a change in pull request #29064:
URL: https://github.com/apache/spark/pull/29064#discussion_r453520007
##########
File path: sql/core/src/test/resources/sql-tests/results/timezone.sql.out
##########
@@ -0,0 +1,121 @@
+-- Automatically generated by SQLQueryTestSuite
+-- Number of queries: 11
+
+
+-- !query
+SET TIME ZONE 'Asia/Hong_Kong'
+-- !query schema
+struct<key:string,value:string>
+-- !query output
+spark.sql.session.timeZone Asia/Hong_Kong
Review comment:
This looks like a weird output for `SET TIME ZONE 'Asia/Hong_Kong'`.
Shall we add a `Project` node on the `SetCommand` to give better output>
##########
File path: sql/core/src/test/resources/sql-tests/results/timezone.sql.out
##########
@@ -0,0 +1,121 @@
+-- Automatically generated by SQLQueryTestSuite
+-- Number of queries: 11
+
+
+-- !query
+SET TIME ZONE 'Asia/Hong_Kong'
+-- !query schema
+struct<key:string,value:string>
+-- !query output
+spark.sql.session.timeZone Asia/Hong_Kong
Review comment:
This looks like a weird output for `SET TIME ZONE 'Asia/Hong_Kong'`.
Shall we add a `Project` node on the `SetCommand` to give better output?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
