yaooqinn commented on a change in pull request #29064:
URL: https://github.com/apache/spark/pull/29064#discussion_r453524124
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -240,6 +240,10 @@ statement
| MSCK REPAIR TABLE multipartIdentifier
#repairTable
| op=(ADD | LIST) identifier (STRING | .*?)
#manageResource
| SET ROLE .*?
#failNativeCommand
+ | SET TIME ZONE ALL
#listTimeZones
+ | SET TIME ZONE interval
#setTimeZone
+ | SET TIME ZONE timezone=(STRING | LOCAL)
#setTimeZone
+ | SET TIME ZONE .*?
#setTimeZone
Review comment:
this is used to fail invalid set time zone syntax explicitly, cuz' now
we support
```sql
spark-sql (default)> set time zone abcd;
key value
time zone abcd <undefined>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
