gaborgsomogyi commented on a change in pull request #29024: URL: https://github.com/apache/spark/pull/29024#discussion_r454183194
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala ########## @@ -23,12 +23,15 @@ import java.util.{Locale, Properties} import org.apache.commons.io.FilenameUtils import org.apache.spark.SparkFiles +import org.apache.spark.annotation.DeveloperApi import org.apache.spark.internal.Logging import org.apache.spark.sql.catalyst.util.CaseInsensitiveMap /** + * ::DeveloperApi:: * Options for the JDBC data source. */ +@DeveloperApi Review comment: We could pass the 2 params but then we limit further implementation possibilities so I would vote on the map. At the moment there is no need other params other than `keytab` and `principal` but later providers may need further things. It's not a strong opinion, just don't want to close later possibilities. If we agree on the way I'll do the changes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org