cloud-fan commented on a change in pull request #29045:
URL: https://github.com/apache/spark/pull/29045#discussion_r454476253
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcQuerySuite.scala
##########
@@ -288,4 +288,35 @@ class HiveOrcQuerySuite extends OrcQueryTest with
TestHiveSingleton {
}
}
}
+
+ test("SPARK-32234: orc data created by the hive tables having _col fields
name" +
+ " for ORC_IMPLEMENTATION") {
+ Seq("native", "hive").foreach { orcImpl =>
+ Seq("false", "true").foreach { vectorized =>
+ withSQLConf(
+ SQLConf.ORC_IMPLEMENTATION.key -> orcImpl,
+ SQLConf.ORC_VECTORIZED_READER_ENABLED.key -> vectorized) {
+ withTempPath { dir =>
+ withTable("test_hive_orc_impl") {
+ spark.sql(
+ s"""
+ | CREATE TABLE test_hive_orc_impl
+ | (_col1 INT, _col2 STRING, _col3 INT)
Review comment:
can this test reproduce the bug? the table schema matches the physical
file schema.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
