huaxingao commented on a change in pull request #29115:
URL: https://github.com/apache/spark/pull/29115#discussion_r455249866
##########
File path: mllib/src/main/scala/org/apache/spark/mllib/util/MLUtils.scala
##########
@@ -534,8 +534,10 @@ object MLUtils extends Logging {
norm2: Double,
precision: Double = 1e-6): Double = {
val n = v1.size
- require(v2.size == n)
- require(norm1 >= 0.0 && norm2 >= 0.0)
+ require(v2.size == n,
+ s"Both vectors should have same length, found v1 is $n while v2 is
${v2.size}")
+ require(norm1 >= 0.0 && norm2 >= 0.0,
+ s"Both norms should be greater or equal to 0.0, found norm1=${norm1},
norm2=${norm2}")
Review comment:
super nit: `${norm1}` -> `$norm1` and `${norm2}` -> `$norm2`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
