Github user freeman-lab commented on the pull request:
https://github.com/apache/spark/pull/5037#issuecomment-86736605
Agreed @tdas ! Discussed with @mengxr offline today and I think we're
satisfied with this fix. Any additional suggestions, or extra tests?
I want to make the same change in StreamingKMeans (and add expanded tests).
As we discussed today, it's not a problem there, because of how the model is
updated, but it will avoid confusion moving forward. But I'll do that as a
separate PR because we won't need to include that change with updates to
earlier versions as we will want to do here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
