[GitHub] [spark] AngersZhuuuu commented on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

[GitBox]

AngersZhuuuu commented on pull request #29085:
URL: https://github.com/apache/spark/pull/29085#issuecomment-660879513


   > **[Test build #126162 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126162/testReport)**
 for PR 29085 at commit 
[`e16c136`](https://github.com/apache/spark/commit/e16c13620032f8062cb0fcd6ecad9836c97febf7).
   > 
   > * This patch **fails Spark unit tests**.
   > * This patch merges cleanly.
   > * This patch adds no public classes.
   
   
   @maropu according to this failed UT, 
   
   <img width="849" alt="Screen Shot 2020-07-20 at 4 16 30 PM" 
src="https://user-images.githubusercontent.com/46485123/87915370-ab8fd980-caa4-11ea-8792-9bba53fa5b4d.png";>
   
   Add back 
   ```
         case DateType if conf.datetimeJava8ApiEnabled =>
           wrapperConvertException(data => DateTimeUtils.stringToDate(
             UTF8String.fromString(data),
             DateTimeUtils.getZoneId(conf.sessionLocalTimeZone))
             .map(DateTimeUtils.daysToLocalDate).orNull, converter)
         case TimestampType if conf.datetimeJava8ApiEnabled =>
            wrapperConvertException(data => DateTimeUtils.stringToTimestamp(
             UTF8String.fromString(data),
             DateTimeUtils.getZoneId(conf.sessionLocalTimeZone))
             .map(DateTimeUtils.microsToInstant).orNull, converter)
   
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org