leanken edited a comment on pull request #29104: URL: https://github.com/apache/spark/pull/29104#issuecomment-660991285
@agrawaldevesh @maropu @cloud-fan Update digest as follow. 1. update HashedRelation to carry inputEmpty and anyNullKeyExists information 2. BroadcastHashJoinExec support both codegen and non-codegen with isNullAwareAntiJoin set. 3. BroadcastNullAwareHashJoinExec support both codegen and non-codegen. 4. remove pattern match into patterns.scala 5. remove NotInSubqueryHashJoinParams since HashedRelation carry inputEmpty and anyNullKeyExists, and streamedKey and streamedKeyIndex is no longer needed. 6. update JoinSuite with hand written left anti join case. 7. add spark.sql.nullAware.antiJoin.optimize.use.bhj to apply optimize using BroadcastHashJoinExec 8. other minor code refine. 9. remove singleColumnNotInSubquery, use singleColumn NullAwareAntiJoin instead. ping for update review, many thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
