agrawaldevesh commented on a change in pull request #29032:
URL: https://github.com/apache/spark/pull/29032#discussion_r457764133
##########
File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
##########
@@ -871,7 +871,7 @@ private[deploy] class Master(
logInfo("Telling app of decommission executors")
exec.application.driver.send(ExecutorUpdated(
exec.id, ExecutorState.DECOMMISSIONED,
- Some("worker decommissioned"), None, workerLost = false))
+ Some("worker decommissioned"), None, workerLost = true))
Review comment:
The short answer is that I sort of hacked it here :-)
So on line 186 of StandaloneAppClient.scala in this PR: I actually plumb the
workerLost (= true) here into ExecutorDecommissionInfo.isHostDecommissioned.
The proper thing to do here would be to not communicate executor
decommissioning via ExecutorUpdated in the standalone codepath. But instead
have a separate ExecutorDecommissioned message that can take the
ExecutorDecommissionInfo. The ExecutorDecommissionInfo should be prepared by
the cluster manager directly, since it has the most context about the decom is
happening (ie exactly what pieces would be going away).
This is just a slightly bigger change and maybe I should just do it here.
Let me try it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
