Github user witgo commented on a diff in the pull request:

    https://github.com/apache/spark/pull/569#discussion_r12027354
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -1056,4 +1055,11 @@ private[spark] object Utils extends Logging {
       def getHadoopFileSystem(path: String): FileSystem = {
         getHadoopFileSystem(new URI(path))
       }
    +
    +  /**
    +   * return true if this is Windows.
    +   */
    +  def isWindows = Option(System.getProperty("os.name")).
    --- End diff --
    
    @srowen
    ```scala
    def isWindows(): Boolean = {
      try {
        val osName = System.getProperty("os.name")
        osName != null && osName.startsWith("Windows")
      } catch {
        case e: SecurityException => (log a warning and return false)
      }
    }
    ````
    You think here will be thrown a SecurityException .Why?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to