leanken commented on a change in pull request #29104:
URL: https://github.com/apache/spark/pull/29104#discussion_r457908392



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala
##########
@@ -498,6 +547,8 @@ case class BroadcastHashJoinExec(
          |    }
          |  }
          |}
+         |// special case for NullAwareAntiJoin, if anyNull in streamedRow, 
row should be dropped.

Review comment:
       done 
   update code like 
   
   ```
   case EqualTo(l, r) if canEvaluate(l, left) && canEvaluate(r, right) => 
Some((l, r))
   case EqualTo(l, r) if canEvaluate(l, right) && canEvaluate(r, left) => 
Some((r, l))
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to