maropu commented on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662210957
>> I meant the behaivour of v3.0.0. Either way, this PR is getting larger, so I think its okay to support it in follow-ups. >All right, really too big. Keep like this The current main code part looks almost okay, but IMO we need more tests for better test coverage as commented above. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org