cloud-fan commented on a change in pull request #29160:
URL: https://github.com/apache/spark/pull/29160#discussion_r458645317
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala
##########
@@ -290,7 +290,7 @@ class DataFrameReader private[sql](sparkSession:
SparkSession) extends Logging {
// properties should override settings in extraOptions.
this.extraOptions ++= properties.asScala
// explicit url and dbtable should override all
- this.extraOptions += (JDBCOptions.JDBC_URL -> url,
JDBCOptions.JDBC_TABLE_NAME -> table)
+ this.extraOptions ++= Map(JDBCOptions.JDBC_URL -> url,
JDBCOptions.JDBC_TABLE_NAME -> table)
Review comment:
The API requires `TraversableOnce`, so here we can use `Seq` instead of
`Map`?
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala
##########
@@ -768,7 +769,7 @@ final class DataFrameWriter[T] private[sql](ds: Dataset[T])
{
// connectionProperties should override settings in extraOptions.
this.extraOptions ++= connectionProperties.asScala
// explicit url and dbtable should override all
- this.extraOptions += ("url" -> url, "dbtable" -> table)
+ this.extraOptions ++= Map("url" -> url, "dbtable" -> table)
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
