squito commented on a change in pull request #28848:
URL: https://github.com/apache/spark/pull/28848#discussion_r458853672



##########
File path: 
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
##########
@@ -548,6 +560,56 @@ class DAGSchedulerSuite extends SparkFunSuite with 
LocalSparkContext with TimeLi
     assert(mapStatus2(2).location.host === "hostB")
   }
 
+  test("SPARK-32003: All shuffle files for executor should be cleaned up on 
fetch failure") {

Review comment:
       personally, I'm OK with this as is, I think its OK for some of the 
details to be down in the test itself and balance a super-duper long name.
   
   @dongjoon-hyun since you called this a nit I'm assuming you're OK with me 
merging this anyhow, but if not lemme know, can submit a quick followup.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to