srowen commented on a change in pull request #29196:
URL: https://github.com/apache/spark/pull/29196#discussion_r459174022
##########
File path:
core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala
##########
@@ -309,14 +311,18 @@ class HistoryServerSuite extends SparkFunSuite with
BeforeAndAfter with Matchers
val urlsThroughKnox = responseThroughKnox \\ "@href" map (_.toString)
val siteRelativeLinksThroughKnox = urlsThroughKnox filter
(_.startsWith("/"))
- all (siteRelativeLinksThroughKnox) should startWith (knoxBaseUrl)
+ for (link <- siteRelativeLinksThroughKnox) {
+ link should startWith (knoxBaseUrl)
+ }
val directRequest = mock[HttpServletRequest]
val directResponse = page.render(directRequest)
val directUrls = directResponse \\ "@href" map (_.toString)
val directSiteRelativeLinks = directUrls filter (_.startsWith("/"))
- all (directSiteRelativeLinks) should not startWith (knoxBaseUrl)
+ for (link <- directSiteRelativeLinks) {
Review comment:
Had to change up the scalatest syntax in some `all(...) should ...`
cases to get it to keep working in 3.2.0+ ; should be equivalent
##########
File path: core/src/main/scala/org/apache/spark/api/java/JavaSparkContext.scala
##########
@@ -727,7 +727,7 @@ class JavaSparkContext(val sc: SparkContext) extends
Closeable {
* @note This does not necessarily mean the caching or computation was
successful.
*/
def getPersistentRDDs: JMap[java.lang.Integer, JavaRDD[_]] = {
- sc.getPersistentRDDs.mapValues(s => JavaRDD.fromRDD(s))
+ sc.getPersistentRDDs.mapValues(s => JavaRDD.fromRDD(s)).toMap
Review comment:
This was another test fix for 2.13 I picked up along the way
##########
File path: pom.xml
##########
@@ -892,7 +907,25 @@
<dependency>
<groupId>org.scalatest</groupId>
<artifactId>scalatest_${scala.binary.version}</artifactId>
- <version>3.0.8</version>
+ <version>3.2.0</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.scalatestplus</groupId>
+
<artifactId>scalatestplus-scalacheck_${scala.binary.version}</artifactId>
+ <version>3.1.0.0-RC2</version>
Review comment:
These lib-specific integrations are apparently separate now, so are
added to the test build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
