Ngone51 commented on a change in pull request #28911:
URL: https://github.com/apache/spark/pull/28911#discussion_r459264839
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -1415,10 +1415,16 @@ package object config {
private[spark] val SHUFFLE_HOST_LOCAL_DISK_READING_ENABLED =
ConfigBuilder("spark.shuffle.readHostLocalDisk")
- .doc(s"If enabled (and `${SHUFFLE_USE_OLD_FETCH_PROTOCOL.key}` is
disabled and external " +
- s"shuffle `${SHUFFLE_SERVICE_ENABLED.key}` is enabled), shuffle " +
- "blocks requested from those block managers which are running on the
same host are read " +
- "from the disk directly instead of being fetched as remote blocks over
the network.")
+ .doc("When enabled, shuffle blocks requested from those block managers
which are running " +
+ "on the same host are read from the disk directly instead of being
fetched as remote " +
+ "blocks over the network. Note that for k8s workloads, this only works
when nodes are " +
+ "using non-isolated container storage." +
+ s"To enable the feature, one should disable
${SHUFFLE_USE_OLD_FETCH_PROTOCOL.key} first." +
+ " And make sure that one of the following requirements are
satisfied:\n" +
+ s"1. external shuffle service is enabled
(${SHUFFLE_SERVICE_ENABLED.key});" +
+ s"2. dynamic allocation is disabled (${DYN_ALLOCATION_ENABLED.key});" +
+ s"3. dynamic allocation is enabled with shuffle tracking " +
+ s"(${DYN_ALLOCATION_SHUFFLE_TRACKING_ENABLED});")
Review comment:
Please take a look at the updated document regarding the dynamic
allocation. cc: @holdenk @attilapiros
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
