Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/4259#discussion_r27333012
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/sharedParams.scala
---
@@ -34,6 +34,43 @@ private[ml] trait HasRegParam extends Params {
def getRegParam: Double = get(regParam)
}
+private[ml] trait HasElasticNetParam extends HasRegParam {
--- End diff --
Definitely. It seems that there is no easy way to specify the valid
parameter range or requirement in this framework. Do you think it's a good idea
that I add the check like the following?
```scala
def getElasticNetParam: Double = {
val elasticNetParam = get(elasticNetParam)
require(elasticNetParam >= 0)
require(elasticNetParam <= 1)
elasticNetParam
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
