cloud-fan commented on a change in pull request #29220:
URL: https://github.com/apache/spark/pull/29220#discussion_r459932783
##########
File path: sql/core/src/test/resources/sql-tests/inputs/datetime-parsing.sql
##########
@@ -1,5 +1,68 @@
--- TESTS FOR DATETIME PARSING FUNCTIONS ---
+-- parsing with pattern 'y'
+select to_timestamp('1', 'y');
+select to_timestamp('12', 'y');
+select to_timestamp('123', 'y');
+select to_timestamp('1234', 'y');
+select to_timestamp('12345', 'y');
+select to_timestamp('123456', 'y');
+
+select to_timestamp('12', 'yy');
+
+select to_timestamp('123', 'yyy');
Review comment:
I would simply test 3 `y`s and max number of `y`s.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
