cloud-fan commented on a change in pull request #29220:
URL: https://github.com/apache/spark/pull/29220#discussion_r460089355
##########
File path:
sql/core/src/test/resources/sql-tests/inputs/datetime-parsing-invalid.sql
##########
@@ -1,5 +1,14 @@
--- TESTS FOR DATETIME PARSING FUNCTIONS WITH INVALID VALUES ---
+-- parsing invalid value with pattern 'y'
+select to_timestamp('300000', 'y');
+select to_timestamp('1', 'yy');
+select to_timestamp('-12', 'yy');
+select to_timestamp('123', 'yy');
Review comment:
can we add some comments to explain why they should fail?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
