agrawaldevesh commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460141178
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ########## @@ -454,6 +491,48 @@ case class BroadcastHashJoinExec( val (matched, checkCondition, _) = getJoinCondition(ctx, input) val numOutput = metricTerm(ctx, "numOutputRows") + // fast stop if isOriginalInputEmpty = true, should accept all rows in streamedSide + if (broadcastRelation.value.isOriginalInputEmpty) { + return s""" + |// Anti Join isOriginalInputEmpty(true) accept all + |$numOutput.add(1); + |${consume(ctx, input)} + """.stripMargin + } + + if (isNullAwareAntiJoin) { + if (broadcastRelation.value.allNullColumnKeyExistsInOriginalInput) { + return s""" + |// NAAJ Review comment: Thanks for teaching us about this @cloud-fan !. Given how hard this, let's table this for future. @leanken, Thanks for persisting in trying to find a solution for this. I learnt something from your efforts :-). But I agree that this is a "Resolve Later :-P". ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org