rdblue commented on a change in pull request #28617: URL: https://github.com/apache/spark/pull/28617#discussion_r460272432
########## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/SupportsPartitions.java ########## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.connector.catalog; + +import java.util.Map; + +import org.apache.spark.annotation.Experimental; + +/** + * Catalog methods for working with Partitions. + */ +@Experimental +public interface SupportsPartitions extends TableCatalog { + + /** + * Create partitions in an existing table, assuming it exists. + * + * @param ident a table identifier + * @param partitions transforms to use for partitioning data in the table + * @param ignoreIfExists + */ + void createPartitions( + Identifier ident, + TablePartition[] partitions, + Boolean ignoreIfExists); + + /** + * Drop partitions from a table, assuming they exist. + * + * @param ident a table identifier + * @param partitions a list of string map for existing partitions + * @param ignoreIfNotExists + */ + void dropPartitions( + Identifier ident, + Map<String, String>[] partitions, + Boolean ignoreIfNotExists); + + /** + * Override the specs of one or many existing table partitions, assuming they exist. + * + * @param ident a table identifier + * @param oldpartitions a list of string map for existing partitions to be renamed + * @param newPartitions a list of string map for new partitions + */ + void renamePartitions( + Identifier ident, + Map<String, String>[] oldpartitions, + Map<String, String>[] newPartitions); + + /** + * Alter one or many table partitions whose specs that match those specified in `parts`, + * assuming the partitions exist. + * + * @param ident a table identifier + * @param partitions transforms to use for partitioning data in the table + */ + void alterPartitions( + Identifier ident, + TablePartition[] partitions); Review comment: Okay, a couple of questions, then. First, does this need to be batched? Is there a Hive MetaStore call that this should correspond to to avoid too many RPCs? If not, then it would be better to alter a single partition at a time, right? Second, what changing this to `replacePartitionMetadata(identifier, properties)`? That is more clear about what "alter" means. With just the verb "alter", it isn't clear whether the properties are supposed to replace or add to existing properties. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
