leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460275829
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ########## @@ -81,6 +81,34 @@ private[execution] sealed trait HashedRelation extends KnownSizeEstimation { */ def asReadOnlyCopy(): HashedRelation + + /** + * Normally HashedRelation is built from an Source (input: Iterator[InternalRow]). + * This indicates the original input is empty. + * Note that, the hashed relation can be empty despite the input being not empty, + * since the hashed relation skips over null keys. + */ + var isOriginalInputEmpty: Boolean + + def setOriginalInputEmtpy(isOriginalInputEmpty: Boolean): HashedRelation = { + this.isOriginalInputEmpty = isOriginalInputEmpty + this + } + + /** + * It's only used in null aware anti join. + * This will be set true if Source (input: Iterator[InternalRow]) contains a key, + * which is allNullColumn. Review comment: removed ########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ########## @@ -81,6 +81,34 @@ private[execution] sealed trait HashedRelation extends KnownSizeEstimation { */ def asReadOnlyCopy(): HashedRelation + + /** + * Normally HashedRelation is built from an Source (input: Iterator[InternalRow]). + * This indicates the original input is empty. + * Note that, the hashed relation can be empty despite the input being not empty, + * since the hashed relation skips over null keys. + */ + var isOriginalInputEmpty: Boolean + + def setOriginalInputEmtpy(isOriginalInputEmpty: Boolean): HashedRelation = { + this.isOriginalInputEmpty = isOriginalInputEmpty + this + } + + /** + * It's only used in null aware anti join. + * This will be set true if Source (input: Iterator[InternalRow]) contains a key, + * which is allNullColumn. + */ + var allNullColumnKeyExistsInOriginalInput: Boolean + + def setAllNullColumnKeyExistsInOriginalInput( + allNullColumnKeyExistsInOriginalInput: Boolean): HashedRelation = { + this.allNullColumnKeyExistsInOriginalInput = Review comment: done. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org