sarutak commented on a change in pull request #29002: URL: https://github.com/apache/spark/pull/29002#discussion_r460346359
########## File path: core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala ########## @@ -402,6 +403,73 @@ class ExecutorSuite extends SparkFunSuite assert(taskMetrics.getMetricValue("JVMHeapMemory") > 0) } + test("SPARK-32175: Plugin initialization should start after heartbeater started") { + withTempDir { tempDir => + val sparkPluginCodeBody = + """ + |@Override + |public org.apache.spark.api.plugin.ExecutorPlugin executorPlugin() { + | return new TestExecutorPlugin(); + |} + | + |@Override + |public org.apache.spark.api.plugin.DriverPlugin driverPlugin() { return null; } + """.stripMargin + val executorPluginBody = + """ + |@Override + |public void init( + | org.apache.spark.api.plugin.PluginContext ctx, + | java.util.Map<String, String> extraConf) { + | try { + | Thread.sleep(30 * 1000); + | } catch (InterruptedException e) { + | throw new RuntimeException(e); + | } + |} + """.stripMargin + + val compiledExecutorPlugin = TestUtils.createCompiledClass( + "TestExecutorPlugin", + tempDir, + "", + null, + Seq.empty, + Seq("org.apache.spark.api.plugin.ExecutorPlugin"), + executorPluginBody) + + val thisClassPath = + sys.props("java.class.path").split(File.pathSeparator).map(p => new File(p).toURI.toURL) + val compiledSparkPlugin = TestUtils.createCompiledClass( + "TestSparkPlugin", + tempDir, + "", + null, + Seq(tempDir.toURI.toURL) ++ thisClassPath, + Seq("org.apache.spark.api.plugin.SparkPlugin"), + sparkPluginCodeBody) + + val jarUrl = TestUtils.createJar( + Seq(compiledSparkPlugin, compiledExecutorPlugin), + new File(tempDir, "testPlugin.jar")) + + val unusedJar = TestUtils.createJarWithClasses(Seq.empty) + val args = Seq( + "--class", SimpleApplicationTest.getClass.getName.stripSuffix("$"), + "--name", "testApp", + "--master", "local-cluster[1,1,1024]", + "--conf", "spark.plugins=TestSparkPlugin", + "--conf", "spark.storage.blockManagerSlaveTimeoutMs=" + 10 * 1000, + "--conf", "spark.network.timeoutInterval=" + 10 * 1000, + "--conf", "spark.executor.heartbeatInterval=" + 5 * 1000, + "--conf", "spark.executor.extraClassPath=" + jarUrl.toString, + "--conf", "spark.driver.extraClassPath=" + jarUrl.toString, + "--conf", "spark.ui.enabled=false", + unusedJar.toString) + SparkSubmitSuite.runSparkSubmit(args, timeout = 2.minutes) Review comment: 8 seconds works on my laptop so let's go with the number. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org