dongjoon-hyun commented on a change in pull request #29227: URL: https://github.com/apache/spark/pull/29227#discussion_r460355637
########## File path: bin/load-spark-env.cmd ########## @@ -37,26 +37,24 @@ if [%SPARK_ENV_LOADED%] == [] ( rem Setting SPARK_SCALA_VERSION if not already set. -rem TODO: revisit for Scala 2.13 support -set SPARK_SCALA_VERSION=2.12 -rem if [%SPARK_SCALA_VERSION%] == [] ( -rem set SCALA_VERSION_1=2.12 -rem set SCALA_VERSION_2=2.11 -rem -rem set ASSEMBLY_DIR1=%SPARK_HOME%\assembly\target\scala-%SCALA_VERSION_1% -rem set ASSEMBLY_DIR2=%SPARK_HOME%\assembly\target\scala-%SCALA_VERSION_2% -rem set ENV_VARIABLE_DOC=https://spark.apache.org/docs/latest/configuration.html#environment-variables -rem if exist %ASSEMBLY_DIR2% if exist %ASSEMBLY_DIR1% ( -rem echo "Presence of build for multiple Scala versions detected (%ASSEMBLY_DIR1% and %ASSEMBLY_DIR2%)." -rem echo "Remove one of them or, set SPARK_SCALA_VERSION=%SCALA_VERSION_1% in %SPARK_ENV_CMD%." -rem echo "Visit %ENV_VARIABLE_DOC% for more details about setting environment variables in spark-env.cmd." -rem echo "Either clean one of them or, set SPARK_SCALA_VERSION in spark-env.cmd." -rem exit 1 -rem ) -rem if exist %ASSEMBLY_DIR1% ( -rem set SPARK_SCALA_VERSION=%SCALA_VERSION_1% -rem ) else ( -rem set SPARK_SCALA_VERSION=%SCALA_VERSION_2% -rem ) -rem ) +if [%SPARK_SCALA_VERSION%] == [] ( + set SCALA_VERSION_1=2.12 Review comment: Got it. Thanks! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
