dongjoon-hyun commented on a change in pull request #29312: URL: https://github.com/apache/spark/pull/29312#discussion_r463389867
########## File path: .github/workflows/master.yml ########## @@ -271,3 +271,29 @@ jobs: mkdir -p ~/.m2 ./build/mvn $MAVEN_CLI_OPTS -DskipTests -Pyarn -Pmesos -Pkubernetes -Phive -Phive-thriftserver -Phadoop-cloud -Djava.version=11 install rm -rf ~/.m2/repository/org/apache/spark + + scala213: + name: Scala 2.13 + runs-on: ubuntu-latest + steps: + - name: Checkout Spark repository + uses: actions/checkout@v2 + - name: Cache Maven local repository + uses: actions/cache@v2 + with: + path: ~/.m2/repository + key: scala213-maven-${{ hashFiles('**/pom.xml') }} + restore-keys: | + scala213-maven- + - name: Install Java 11 + uses: actions/setup-java@v1 + with: + java-version: 11 + - name: Test with Maven + run: | + export MAVEN_OPTS="-Xmx2g -XX:ReservedCodeCacheSize=1g -Dorg.slf4j.simpleLogger.defaultLogLevel=WARN" + export MAVEN_CLI_OPTS="--no-transfer-progress" + mkdir -p ~/.m2 + dev/change-scala-version.sh 2.13 + build/mvn test -pl core --am -Pscala-2.13 Review comment: I prefer to have a green light always in three ways. 1. If CI fails always, nobody will care about that. 2. It cannot protect `core` itself. Without looking at the log detail, there is no difference between `core` failure and `beyond core` failure 3. GitHub Action update is cheap because we can do that in a few hours (PR Passing) while Jenkins update is heavy. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org