maropu commented on a change in pull request #29303:
URL: https://github.com/apache/spark/pull/29303#discussion_r463592697



##########
File path: 
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerWithSparkContextSuite.scala
##########
@@ -101,6 +104,79 @@ trait ThriftServerWithSparkContextSuite extends 
SharedThriftServer {
       }
     }
   }
+
+  test("SparkGetColumnsOperation") {
+    val schemaName = "default"
+    val tableName = "spark_get_col_operation"
+    val decimalType = DecimalType(10, 2)
+    val ddl =
+      s"""
+         |CREATE TABLE $schemaName.$tableName

Review comment:
       I think we don't have a strict rule for the format though, how about 
following the existing format?
   
https://github.com/apache/spark/blob/8014b0b5d61237dc4851d4ae9927778302d692da/sql/core/src/test/scala/org/apache/spark/sql/ShowCreateTableSuite.scala#L35-L41




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to