leanken commented on pull request #29304: URL: https://github.com/apache/spark/pull/29304#issuecomment-667788398
I just found out a negative case for it it should return (1,2,3) in expansion solution, but it return nothing in BNLJ. you are right about the correctness, let me rethink and come back to you later. ``` spark.sql( """ |CREATE TEMPORARY VIEW m AS SELECT * FROM VALUES | (1, 2, 3) | AS m(a, b, c) """.stripMargin).collect() spark.sql( """ |CREATE TEMPORARY VIEW s AS SELECT * FROM VALUES | (1, null, 3) | AS s(c, d, e) """.stripMargin).collect() spark.sql( """ |select * from m where (a,b,c) not in (select * from s) """.stripMargin).collect().foreach(println) ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org