agrawaldevesh commented on a change in pull request #29211:
URL: https://github.com/apache/spark/pull/29211#discussion_r465267465
##########
File path:
core/src/test/scala/org/apache/spark/storage/BlockManagerDecommissionUnitSuite.scala
##########
@@ -77,13 +187,30 @@ class BlockManagerDecommissionUnitSuite extends
SparkFunSuite with Matchers {
try {
bmDecomManager.start()
- eventually(timeout(5.second), interval(10.milliseconds)) {
+ var previousRDDTime = Long.MaxValue
+ var previousShuffleTime = Long.MaxValue
+
+ // We don't check that all blocks are migrated because out mock is
always returning an RDD.
+ eventually(timeout(10.second), interval(10.milliseconds)) {
assert(bmDecomManager.shufflesToMigrate.isEmpty == true)
- verify(bm, times(1)).replicateBlock(
+ verify(bm, least(1)).replicateBlock(
mc.eq(storedBlockId1), mc.any(), mc.any(), mc.eq(Some(3)))
verify(blockTransferService, times(2))
.uploadBlockSync(mc.eq("host2"), mc.eq(bmPort), mc.eq("exec2"),
mc.any(), mc.any(),
mc.eq(StorageLevel.DISK_ONLY), mc.isNull())
+ // Since we never "finish" the RDD blocks make sure the time is always
moving forward.
Review comment:
nit: Since we never "finish" the RDD blocks, make sure the time is
always moving forward. (added comma)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
