rdblue commented on a change in pull request #29339: URL: https://github.com/apache/spark/pull/29339#discussion_r465974060
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/AlterTableAddPartitionExec.scala ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.execution.datasources.v2 + +import scala.collection.JavaConverters._ + +import org.apache.spark.sql.catalyst.InternalRow +import org.apache.spark.sql.catalyst.analysis.PartitionAlreadyExistsException +import org.apache.spark.sql.catalyst.expressions.Attribute +import org.apache.spark.sql.connector.catalog.SupportsPartitions + +/** + * Physical plan node for adding partitions of table. + */ +case class AlterTableAddPartitionExec( + table: SupportsPartitions, + partitions: Seq[(InternalRow, Map[String, String])], + ignoreIfExists: Boolean) extends V2CommandExec { + + override def output: Seq[Attribute] = Seq.empty + + override protected def run(): Seq[InternalRow] = { + partitions.foreach { case (partIdent, properties) => + try { + table.createPartition(partIdent, properties.asJava) Review comment: I think that a variant of `createPartition` that works for multiple partitions should be added as an optional trait, or using optional methods in the existing interface. We want sources to have predictable, standard behavior. I think that means that when adding a single partition in a group fails, the ones that were already successful should be rolled back. That way multiple calls to `createPartition` have the same result as a single call to `createPartitions` and the SQL statement has well-defined and reliable behavior. If we agree on that behavior, then I think it is clear that Spark should handle calling either `createPartition` multiple times or calling `createPartitions` because that's the best way to get reliable behavior, while keeping table implementations simple -- those that don't support an atomic operation just implement `createPartition`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
