tianczha commented on a change in pull request #28618:
URL: https://github.com/apache/spark/pull/28618#discussion_r466028728
##########
File path:
core/src/main/java/org/apache/spark/shuffle/sort/io/LocalDiskShuffleDataIO.java
##########
@@ -35,12 +37,13 @@ public LocalDiskShuffleDataIO(SparkConf sparkConf) {
}
@Override
- public ShuffleExecutorComponents executor() {
+ public ShuffleExecutorComponents initializeShuffleExecutorComponents(
Review comment:
Can we move `initializeShuffleDriverComponents` before
`initializeShuffleExecutorComponents`?
The extraConfigs will be only available after driver components is
initialized, right?
##########
File path:
core/src/main/scala/org/apache/spark/shuffle/ShuffleWriteProcessor.scala
##########
@@ -20,7 +20,7 @@ package org.apache.spark.shuffle
import org.apache.spark.{Partition, ShuffleDependency, SparkEnv, TaskContext}
import org.apache.spark.internal.Logging
import org.apache.spark.rdd.RDD
-import org.apache.spark.scheduler.MapStatus
+import org.apache.spark.scheduler.{MapStatus, MapTaskResult}
Review comment:
remove MapStatus?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
