maropu commented on a change in pull request #29360: URL: https://github.com/apache/spark/pull/29360#discussion_r466111375
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ########## @@ -2690,6 +2690,19 @@ object SQLConf { .booleanConf .createWithDefault(true) + + val GROUPING_WITH_UNION = buildConf("spark.sql.optimizer.grouping") + .doc("When true,enable grouping with union.") + .booleanConf + .createWithDefault(false) + + val GROUPING_EXPAND_PROJECTIONS = buildConf("spark.sql.optimizer.projections.size") + .doc("Split a expand into several smallExpand,which contains the size of projections.It can" + + "reduce the shuffle pressure and improve performance in multidimensional analysis " + + "when data is huge.") + .intConf + .createWithDefault(4) Review comment: Could you check if all the existing tests pass if `spark.sql.optimizer.grouping`=true and `spark.sql.optimizer.projections.size`=1? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org