cloud-fan commented on pull request #29125: URL: https://github.com/apache/spark/pull/29125#issuecomment-669712680
I don't agree to revert the UnsafeRow bug fix. As I said, `UnsafeRow` is very fundamental and we can't tolerant any bugs. I agree that the sum decimal bug becomes more visible with the `UnsafeRow` fix, and I see 2 options (reverting the `UnsafeRow` fix is not an option to me): 1. Backport the actual fix. This brings backward compatibility issues for streaming state store. 2. Fail if overflow happens, regardless of the ansi flag. This is not ideal but at least it's better than 3.0.0/2.x, which we fail overflow when whole-stage-codegen is on, and return wrong answer otherwise. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
