ScrapCodes opened a new pull request #29371:
URL: https://github.com/apache/spark/pull/29371


   
   ### What changes were proposed in this pull request?
   1. URL encode the `ASF_PASSWORD` of the release manager.
   2. force delete a `.gitignore` file as it may be absent, specially in the 
subsequent runs of the script. And causes the release script failure.
   
   ### Why are the changes needed?
   Release script takes hours to run, and if a single failure happens about 
somewhere midway, then either one has to get down to manually doing stuff or re 
run the entire script. (This is my understanding) So, I have made the fixes of 
a few failures, discovered so far.
   
   1. If the release manager password contains a char, that is not allowed in 
URL, then it fails the build at the clone spark step.
   `git clone "https://$ASF_USERNAME:$ASF_PASSWORD@$ASF_SPARK_REPO"; -b 
$GIT_BRANCH`
                  
             ^^^ Fails with bad URL
   
   `ASF_USERNAME` may not be URL encoded, but we need to encode `ASF_PASSWORD`.
   
   2. If the `.gitignore` file is missing, it fails the build at `rm 
.gitignore` step.
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   By running the release for branch-2.4, using both type of passwords, i.e. 
passwords with special chars and without it.
   
   For other branches, will followup in other PRs targeted for those branches.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to