Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4135#issuecomment-87870087 Any update on this? This patch looked good to me overall; the main thrust of my feedback was that the tests here didn't seem sufficient to actually exercise the code added in this patch, but I think that shouldn't be too hard to fix.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org