agrawaldevesh commented on a change in pull request #29342:
URL: https://github.com/apache/spark/pull/29342#discussion_r466556531
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
##########
@@ -76,6 +76,11 @@ private[execution] sealed trait HashedRelation extends
KnownSizeEstimation {
*/
def keys(): Iterator[InternalRow]
+ /**
+ * Returns an iterator for values of InternalRow type.
+ */
+ def values(): Iterator[InternalRow]
Review comment:
nit: Down below this is referred to as a build row. Should values be
renamed to buildRows ? or just rows ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
