holdenk commented on a change in pull request #29367: URL: https://github.com/apache/spark/pull/29367#discussion_r466630246
########## File path: core/src/main/scala/org/apache/spark/ExecutorAllocationClient.scala ########## @@ -81,6 +82,43 @@ private[spark] trait ExecutorAllocationClient { countFailures: Boolean, force: Boolean = false): Seq[String] + /** + * Request that the cluster manager decommission the specified executors. + * Default implementation delegates to kill, scheduler must override + * if it supports graceful decommissioning. + * + * @param executors identifiers of executors & decom info. + * @param adjustTargetNumExecutors whether the target number of executors will be adjusted down + * after these executors have been decommissioned. + * @return the ids of the executors acknowledged by the cluster manager to be removed. + */ + def decommissionExecutors( + executors: Seq[(String, ExecutorDecommissionInfo)], + adjustTargetNumExecutors: Boolean): Seq[String] = { + killExecutors(executors.map(_._1), + adjustTargetNumExecutors, + countFailures = false) + } + + + /** + * Request that the cluster manager decommission the specified executor. + * Default implementation delegates to decommissionExecutors, scheduler can override + * if it supports graceful decommissioning. + * + * @param executorId identifiers of executor to decommission + * @param decommissionInfo information about the decommission (reason, host loss) + * @return whether the request is acknowledged by the cluster manager. + */ + def decommissionExecutor(executorId: String, Review comment: That doesn't match how we handle killExecutor, but I don't have strong feeling s about adding adjustTargetNumExecutors though. Can you explain why you want it to be final? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org