srowen commented on a change in pull request #29383:
URL: https://github.com/apache/spark/pull/29383#discussion_r467178364
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java
##########
@@ -425,6 +425,19 @@ public void putFloats(int rowId, int count, byte[] src,
int srcIndex) {
}
}
+ @Override
+ public void putFloatsLittleEndian(int rowId, int count, byte[] src, int
srcIndex) {
+ if (!bigEndianPlatform) {
Review comment:
Just leave it as-is for consistency, yeah. OK I see we have lots of "as
little endian" variants so maybe this is the best approach for symmetry.
I dont' really know enough about this part to validate the change but it
seems plausible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
