Fokko commented on pull request #29121: URL: https://github.com/apache/spark/pull/29121#issuecomment-670841152
I've taken your comment into account, but it got buried somewhere in the comments :) Allow me to summarize: The rule is being enforced by the flake8 linter. I'll rebase against master in a minute to check if there are any new violations between this PR and master. The remaining suppressed imports can be put into two categories: - Imports that are convenience importers. This is a reference that allows users to import a specific class from another module as well, as demonstrated here: https://github.com/apache/spark/pull/29121#discussion_r456681138 Removing these would break backward compatibility, so we have the be cautious here. - The imports for the xmlrunner. This looks a bit messy, but this is required with the current way of how to run the rests. Removing this would affect the output, as demonstrated in https://github.com/apache/spark/pull/29121#discussion_r461360724 Maybe in the future, we can run the tests together. I would separate this from the current PR. I've created a ticket to keep this on the backlog: https://issues.apache.org/jira/browse/SPARK-32572 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
