maropu commented on a change in pull request #29342:
URL: https://github.com/apache/spark/pull/29342#discussion_r467460122
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala
##########
@@ -58,8 +65,19 @@ case class ShuffledHashJoinExec(
val buildTime = longMetric("buildTime")
val start = System.nanoTime()
val context = TaskContext.get()
+
+ val (isLookupAware, value) =
Review comment:
IIUC we have no strict rules for this case. Basically, I just follow the
existing code and the Databricks style guide:
https://github.com/databricks/scala-style-guide, so its okay to ignore my
nit style comments if you think it make no sense. For example, in this case, I
though
```
val (isLookupAware, value) = <line break> <-- Is this necessary?
if (joinType == FullOuter) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
