maropu commented on a change in pull request #28804:
URL: https://github.com/apache/spark/pull/28804#discussion_r467464857
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2196,6 +2196,34 @@ object SQLConf {
.checkValue(bit => bit >= 10 && bit <= 30, "The bit value must be in
[10, 30].")
.createWithDefault(16)
+
+ val SKIP_PARTIAL_AGGREGATE_MINROWS =
+ buildConf("spark.sql.aggregate.skipPartialAggregate.minNumRows")
+ .internal()
+ .doc("Number of records after which aggregate operator checks if " +
+ "partial aggregation phase can be avoided")
+ .longConf
+ .createWithDefault(100000)
+
+ val SKIP_PARTIAL_AGGREGATE_AGGREGATE_RATIO =
+ buildConf("spark.sql.aggregate.skipPartialAggregate.aggregateRatio")
+ .internal()
+ .doc("Ratio of number of records present in map of Aggregate operator" +
+ "to the total number of records processed by the Aggregate operator")
Review comment:
Please describe not how to compute the ratio, but what this means.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
