Github user zsxwing commented on the pull request:

    https://github.com/apache/spark/pull/5277#issuecomment-87941679
  
    > I am worried about the case where calling EventLoop.stop() from the event 
loop thread itself (which can happen transitively here) leads to a one-threaded 
deadlock, but I guess your other patch addresses this?
    
    Yes.  Calling EventLoop.stop() from the event loop thread itself won't lead 
a one-threaded deadlock.
    
    @JoshRosen Your thoughts about moving these `stop`s out of the lock?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to