cloud-fan commented on a change in pull request #29389:
URL: https://github.com/apache/spark/pull/29389#discussion_r467682537
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala
##########
@@ -82,6 +82,8 @@ case class BroadcastExchangeExec(
"buildTime" -> SQLMetrics.createTimingMetric(sparkContext, "time to
build"),
"broadcastTime" -> SQLMetrics.createTimingMetric(sparkContext, "time to
broadcast"))
+ private var knownRowCount: Option[BigInt] = None
Review comment:
can we be consistent and use `metrics` to hold rowCount? You can follow
how we track `dataSize`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
