c21 commented on pull request #29342: URL: https://github.com/apache/spark/pull/29342#issuecomment-671489650
@cloud-fan - > It complicates the driver side hashed-relation building logic. > It increases the size of the data to be broadcasted. Note: the mark row feature is only active for full outer shuffled hash join. It has nothing to do with broadcast cast join and driver side hash relation building. But if a java on-heap standard bitset is acceptable, I can change the PR with that approach. WDYT? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
