agrawaldevesh commented on pull request #29342: URL: https://github.com/apache/spark/pull/29342#issuecomment-671527296
> ah good point about one key multi value. How about we use a standard hash set and use `(keyIndex, value_index)` as the key? Yeah I think what I was suggesting would have required to expose the "Location.pos" via the HashedRelation.get() call. It is not worth it and lets just go with a HashSet. Btw, can we use LongHashedRelation instead of the HashSet if we can squish the (keyIndex, valueIndex) into a single long number ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
