LuciferYang commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672566297


   The main change of Address 
[5328d33](https://github.com/apache/spark/pull/29370/commits/5328d33cc0fe138a5d1de9c73285ef262209e6dc)
 is add a sort
   
   - Add a `sorted` to ensure `duplicateColumns` string in 
`SchemaUtils#checkColumnNameDuplication` method error message have a 
deterministic order because 
   
   `IterableOps.groupBy` in Scala 2.13 and ` TraversableLike.groupBy` in Scala 
2.12 have diffent result order
   
   `IterableOps#groupBy` 和 `TraversableLike#groupBy` 的结果具有不同的顺序
   
   The effect as follow:
   
   - Pass `SchemaUtilsSuite ` 
   
   **Before**
   ```
   Tests: succeeded 4035, failed 17, canceled 0, ignored 6, pending 0
   *** 1 SUITE ABORTED ***
   *** 17 TESTS FAILED ***
   ```
   **After**
   ```
   Tests: succeeded 4035, failed 17, canceled 0, ignored 6, pending 0
   *** 1 SUITE ABORTED ***
   *** 15 TESTS FAILED ***
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to